fix(async-io): return coro when __name__ is not present #2541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
xrmx
reviewed
May 23, 2024
povilasv
force-pushed
the
fix-coroutine-name2
branch
from
2160909 to
db33903
Compare
lzchen
approved these changes
May 23, 2024
shadchin
pushed a commit
to shadchin/opentelemetry-python-contrib
that referenced
this pull request
May 29, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2340
Seems to be we need to return coro when name is not present as per #2521 (comment)
Though demo app and unit test works in both cases 🤔
I guess it's still better for consistency
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Running:
Installing dev dependency and running:
python3 anext.py
from the issue - #2340
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.